Mike JS. Choi
Mike JS. Choi
@stoivo Great idea!
This has been implemented with https://github.com/mkchoi212/fac/commit/afe83276261947c0502675880c1c85b662749031! It hasn't been released yet but I would love to get your feedback on the current implementation! To get the latest version of fac,...
@stoivo Hmmm I will look in to it. Thanks for the feedback though 👍
@stoivo The bug has been fixed with https://github.com/mkchoi212/fac/commit/d93d37e9ccac9ce551e3fd9452bb414d6ffe4e3c, I think 🤔 Could you give it a swirl?
Oh I didn't realize the code breaks when you have a flag in the `EDITOR` environment variable. I will fix that real quick 👍
Not sure if this is the most elegant solution but https://github.com/mkchoi212/fac/commit/9c16b8a82794095c288c0f2c85b8d741facf2f34 fixes the issue! Let me know if it works for ya :D
>It would be great if you created a FAC_EDITOR environment variable... I will definitely look into that 👍 > But nothing happens when you solve the conflict... Hmm I can't...
Ah I see what you did. If you look at https://camo.githubusercontent.com/0178c2f554229485cbfd94e3439b4f27d093d2fe/68747470733a2f2f692e696d6775722e636f6d2f47734a4d5249702e676966, I made it so that the **conflict markers must stay intact**. If not, the prompt turns red, signing an...
Good point. I'm thinking about putting comments like how `git add -p` does it when you press `e` to manually edit code chunk. The only trouble is with Go's `ioutil.Tempfile`,...
Commits have been rebased :D Sorry for noticing it just now!