Few questions and feature requests

[moravveji]

Hi.

I am quite enjoying termgraph; so, first of all, thanks for sharing this nice tool.

I've got few questions and perhaps feature requests.

• In the attached (draft) figure, every bar adds up to 100%, because the values are in percentage. Therefore, it does not make sense to print the sum (i.e. "100") to the right of each bar, anymore. Is there a way to suppress it (e.g. via args)?

• Sometimes a row contains zeros, e.g. for "superdome" the values are basically a 100 and bunch of zeros. Is that the reason that the rightmost end of all rows do not line up? Is there a way to fix this?

• There are two newline spaces between the category printout and the actual bars. Is it possible to let the user decide this (via args)?

Kind regards Ehsan

[mkaz]

• There does not look like there is a flag for suppressing the value labels at the end, that should be easy enough to add.

• Do you have the data you used to generate, ideally if they are all the same value, they should line up. If things are slightly off they may not.

• I'll look into the spacing between category and bars, are you looking for a single blank link instead of two?

[moravveji]

Thanks for considering the comments.

• The arguments passed to the "chart" function are listed below: colors: [91, 94, 92, 93, 95, 96] data: [[5.41871921182266, 4.433497536945813, 79.3103448275862, 9.852216748768473, 0.9852216748768473, 0.0], [22.727272727272727, 40.90909090909091, 22.727272727272727, 13.636363636363637, 0.0, 0.0], [0.0, 14.285714285714286, 85.71428571428571, 0.0, 0.0, 0.0], [0.0, 25.0, 75.0, 0.0, 0.0, 0.0], [0.0, 0.0, 100.0, 0.0, 0.0, 0.0], [83.33333333333333, 0.0, 16.666666666666668, 0.0, 0.0, 0.0]] args: {'no_labels': False, 'vertical': False, 'different_scale': False, 'width': 53, 'format': '{:0.0f}', 'suffix': '', 'stacked': True} labels: ['pbs', 'gpu', 'bigmem', 'amd', 'superdome', 'paid'] I hope this helps you reproduce the figure like mine

• W.r.t. spacing between the categories and bars, it could be also cool if users can specify that via args; I would like to play with it with 0, 1 or 2 lines

[mkaz]

I just released 0.3.0 version that adds a new --no-values flag that will allow you to suppress the values printed at the end.

I'll try to circle back on the other issues when I can.

[moravveji]

Thanks @mkaz, but the effect of choosing --no-values inside termgraph.py is not propagated. It appears only at one place (where args for argparser are defined). Can you please check again if you have pushed the last commit?

[moravveji]

is it possible to temporarily add me to the list of contributors, so that I can push a development branch and start a pull request?

[mkaz]

@moravveji You can fork the repository as your own and still submit a pull request that way.

Here is a good guide on how PRs work with Github.

[moravveji]

@mkaz I forked and started a pull request, but apparently, there is a linter error. Unfortunately, I cannot see/understand the exact error message, and hence have no way to fix this. Would you please let me know how to address the errors?