mkaruza

Results 26 comments of mkaruza

@Tishj if changing submodule helps you can of course do it.

@Tishj Is this issue still valid?

COPY .. TO functionality done with PR #32.

Can we have test for this?

I have updated benchmark for threshold replication in #5293

Tested with increased threshold (1500, 4096). Updated in #5293

***Testing on AWS*** Master, replica and dfly_bench were all running on different ***r6g.xlarge*** machines. Master and replica node were running with default parameters while dfly_bench was executing benchmark as: ```...

After testing with another implementation where replication is done form `JournalStreamer::Write` where data is replicated after reaching threshold and periodic fiber is used only for dispatching stalled non replicate data...

> What was the threshold? It was constant `PendingBuf::kMaxBufSize = 1024` .

Threshold = 1500 ``` ~ THRESHOLD REPLICATION - 1500 / COMMIT SHA: dadb63922f5a878993eb29e7b4db2d65860aa072 ~ #1 Total time: 5m0.010380888s. Overall number of requests: 45003000, QPS: 150010, P99 lat: 3497us Latency summary,...