Markus KARG

Results 557 comments of Markus KARG

There had been not upfront vetos, so I assume everybody is fine with adopting this enhancement. If not, please clearly tell me NOW. Thanks.

Thank you, Alan! I have updated the JavaDocs according to your comments: * Dropped "API compatible with StringReader" from description * @apiNote in StringReader refers to static factory method *...

> /csr @AlanBateman Can you please review [the CSR request](https://bugs.openjdk.org/browse/JDK-8341596) so I can finish it? Thanks!

> > @AlanBateman Can you please review [the CSR request](https://bugs.openjdk.org/browse/JDK-8341596) so I can finish it? Thanks! > > Latest API docs looks good, will you update the CSR? Done. I...

> In a different discussion, I have been told previously that the title of the CSR and the JBS issue for which the CSR is created, should match. I think...

> > @AlanBateman WDYT? > > A title like "Add Reader.of(CharSequence)" would make it clear to everyone what this issue, and the CSR, is about. Changed in PR, RFE and...

> > > @AlanBateman Can you please review [the CSR request](https://bugs.openjdk.org/browse/JDK-8341596) so I can finish it? Thanks! > > > > > > Latest API docs looks good, will you...

> I have looked at the CSR and revised the wording for you, mostly conveying information CSR review wants to see. > @mkarg Can you take a look at this...

I have slightly adapted the copy loop to allow CPUs to use solely single-operand INC within the loop instead of dual-operand ADD.

> > I have slightly adapted the copy loop to allow CPUs to use solely single-operand INC within the loop instead of dual-operand ADD. > > If that makes a...