django-passkeys icon indicating copy to clipboard operation
django-passkeys copied to clipboard

Published 20 hours ago • verified publisher icon mkalioby

Assumption of Bootstrap and Jquery

Open slinkymanbyday opened this issue 1 year ago • 3 comments

The included templates assume bootstrap and jquery are loaded from the projects base templates. These should probably be either included in the projects static files, or mentioned in the documentation.

slinkymanbyday avatar May 21 '23 09:05 slinkymanbyday

Great point. I'll work on adding them to the library but the templates can be overriden by the user.

mkalioby avatar May 21 '23 13:05 mkalioby

i just also stumbled over this issue and i agree: bootstrap and jquery should be loaded in the passkey template.

But even loading jQuery myself i get "Uncaught TypeError: $(...).modal is not a function" .. not sure if i have the right jquery version either (i used this one https://code.jquery.com/jquery-3.7.0.min.js)

kakulukia avatar Jun 10 '23 09:06 kakulukia

Note: The requirement for jQuery and Bootstrap has been added to the documentation a long time ago. Also, #27 would remove the jQuery dependency completely.

I think this Issue may be closed.

rafaelurben avatar Sep 03 '24 15:09 rafaelurben