Mohamed El-Kalioby

icon indicating a website link http://www.mkalioby.com icon indicating an email [email protected]

icon location Cairo Egypt, Riyadh KSA

Results 80 comments of Mohamed El-Kalioby

delKey and toggleKey throw exception on invalid id parameter.

You can open PR for that

Missing migrations

Ok, but there is nothing important as it is about setting id as a BigInt.

Add administration integration to example project

I don't get this, once the LOGIN_URL is set, the login page will be used even for admin app.

Code does not follow PEP8 Style guide

Personally, I'm a fan on PEP8 or black but I can accept a PR for this. Thanks

HTML and Javascript code cleanup

You can open PR for that

HTML and Javascript code cleanup

Also check #27

Tests should be part of the module

That will nice to have, please open a PR for that

Use standard django login functions

This isn't used in any project as this is overridden by `LOGIN_URL`

API view response handling

You can open PR for that

"Blank" 1Password passkey dialog

Hello, Can you try 1Password with example app, and let us know.