mk868
mk868
Thank you for pointing this out, I found the reason Until my change, SpotBugs analysis has been run only for classes enclosed in the `java_library`. For example: [/java/src/org/openqa/selenium/cli/BUILD.bazel](https://github.com/SeleniumHQ/selenium/blob/trunk/java/src/org/openqa/selenium/cli/BUILD.bazel) - SpotBugs...
I merged `trunk` into my branch, SpotBugs related issues should be fixed now. Can we re-run checks?
@diemol Currently we have ~80 NullAway errors only for the `java/src/org/openqa/selenium/BUILD.bazel`:`core` library, for the whole project it's ~1250 errors. I counted these problems using `bazel build //java/... --//java:nullaway_level=WARN 2>&1 |...
Yes, adding a null checker plugin to the CI building is a natural follow-up for nullness annotations. Currently, I've started trying to use [NullAway](https://github.com/uber/NullAway) with Bazel, for this moment I...
Sure! I'll play with it and share the results, I think I'll have something to show and merge next week
@VietND96 the plan is to test nullness annotations using the [NullAway](https://github.com/uber/NullAway). This tool will highlight where null values are passed to NonNull fields. PR with NullAway is here: https://github.com/SeleniumHQ/selenium/pull/14421, but...
@VietND96 PR created: https://github.com/SeleniumHQ/selenium/pull/14882
I pushed one more commit to fix two more NullAway errors (related: https://github.com/SeleniumHQ/selenium/pull/14421). At this point, these errors have been resolved: ``` java/src/org/openqa/selenium/Capabilities.java:36: error: [NullAway] returning @Nullable expression from method...