mk-fg
XULRunner port?
Hi,
Would you be interested in merging a PR that allows Convergence to be built as a XULRunner application which exposes an HTTPS proxy? This would allow any application which supports HTTPS proxies to use Convergence. The code is basically working now in the Namecoin fork of Convergence; it wouldn't be hard to backport it to your codebase.
Cheers, -Jeremy
Not sure what kind of changes it would actually involve, but if it's a large patch adding a separate UI and case-specific hooks all over the place, it sounds like a bad idea - would make changing and testing addon properly way harder.
And separate socks proxy with https termination and http request parsing seem to be like ten lines of python (with twisted), so not sure if it's worth this having fairly complex, hacky and hard-to-maintain (even if due to constant upstream changes) js code instead of a clean and simple separate thing.
But if it's just alternative target in Makefile and such fairly minor stuff, don't see much harm in that, of course.
The only changes necessary are:
- One place in convergence.js uses gBrowser; test to see if it's undefined since XULRunner doesn't have that.
- Hardcode the port in ConvergenceListenSocket.js.
- Add a new folder with the XULRunner-specific files; you can see this folder at https://github.com/JeremyRand/Convergence/tree/xulrunner/client-standalone-files . They're pretty basic and shouldn't need updating often (except bumping the XULRunner max version) even if Convergence changes.
- Modify the makefile a bit.
Not sure if this is too much; let me know what you think.
Looks reasonable to me, can totally merge it. Thanks for taking your time to look into this.