dunnart icon indicating copy to clipboard operation
dunnart copied to clipboard

Assertion failure on deletion of connector

Open skieffer opened this issue 12 years ago • 1 comments

Code:

void ConnRef::makeInactive(void)
{
    COLA_ASSERT(m_active);    
    // Remove from connRefs list.
    m_router->connRefs.erase(m_connrefs_pos);
    m_active = false;
}

skieffer avatar Dec 17 '12 22:12 skieffer

Simple fix might be to replace the method with:

void ConnRef::makeInactive(void)
{
    if (!m_active) { return; }

    // Remove from connRefs list.
    m_router->connRefs.erase(m_connrefs_pos);
    m_active = false;
}

BUT, does this miss some important reason why m_active really SHOULD be true, any time this method is called?

skieffer avatar Dec 17 '12 22:12 skieffer