py-radix icon indicating copy to clipboard operation
py-radix copied to clipboard

Change incompatible pointer type from RadixNodeObject to PyObject

Open robert-scheck opened this issue 1 year ago • 1 comments

Since GCC 14 implicitly casting all pointer types to all other pointer types is no longer allowed. This behavior is now restricted to the void * type and its qualified variations. According to the Python 3 documentation, all object types are extensions of the PyObject type. And it looks like the RadixNodeObject should meet the conditions to be a proper Python object.

See also:

  • https://gcc.gnu.org/gcc-14/porting_to.html#warnings-as-errors
  • https://docs.python.org/3/c-api/list.html#c.PyList_Append
  • https://docs.python.org/3/c-api/structures.html#c.PyObject

Fixes: #57

Thanks to @musicinmybrain and @mbattista for their input and suggestions.

robert-scheck avatar Jun 16 '24 17:06 robert-scheck

I can confirm that this patch fixes the problem for me.

glaubitz avatar Jun 18 '24 10:06 glaubitz

worked for me too

romain-fontugne avatar Oct 14 '24 11:10 romain-fontugne

@mjschultz any chances we get this PR merged?

romain-fontugne avatar Oct 29 '24 07:10 romain-fontugne

Seems I based this project on Travis CI builds, which don't work now(?); if someone wants to move to GHA to build this that would help a lot.

mjschultz avatar Oct 29 '24 16:10 mjschultz