Morgan Rodgers

Results 58 comments of Morgan Rodgers

@micjoswig or other commutative algebra people, do you think you can say something about this?

I have never seen any applications where the entries are allowed to be non-positive, not that I can claim to be an expert on these. I agree that a check...

Can I ask for some clarification on the new `free_module` methods? I find ```julia Oscar.free_module(M::AbstractAlgebra.FPModule, n::Int) = free_module(base_ring(M), n) Oscar.free_module(M::Oscar.ModuleFP, n::Int) = FreeMod(base_ring(M), n) ``` a little strange, because if...

The matrix of all-ones comes up a bit in combinatorial applications, so I can see the advantage to having a `ones_matrix` method (that returns an Oscar matrix).

Ah my mistake, I just assumed Julia used `mul!(a,b)` for `a *= b`, I will look at the AA docs. > On 21. May 2025, at 5:14 PM, Lars Göttgens...

> `+=` and `*=` are probably not the kind of in-place operations @thofma was thinking about, but instead `add!` and `mul!`. See the AA docs for some more in-depth information...

I've got some tests failing in a pathological way, have to do some sorting out... the test does something like this: ```julia x = gens(free_group(2))[2] imgs = QQFieldElem[2,3] g1 =...

It seems that there are cases where we would want an error rather than false when the parents are not `===`. So maybe this inconsistency is hard to avoid. After...

arguably, always throwing an error might be preferable.

I'm taking a look at this, just making a note to let you know that I have seen it.