bibsearch icon indicating copy to clipboard operation
bibsearch copied to clipboard

Adds support for XDG_CONFIG dirs [WIP]

Open cl3wis opened this issue 5 years ago • 5 comments

WRT Issue #35

What's done:

  • removes default config file set in argparser
  • adds method in Config for getting existing config file if arg isn't set

What remains to be done

  • support $XDG_DATA_HOME and $XDG_CACHE_HOME
  • test (unit tests preferably) the various possible scenarios, if it breaks existing config setups, etc

cl3wis avatar Jul 16 '18 16:07 cl3wis

This looks good to me. Do you want me to wait for you to do the other items on the TODO list?

mjpost avatar Jul 26 '18 12:07 mjpost

This code is currently in a working (caveat: tested on a single Linux workstation with no DE installed) state, so there shouldn't be any problem merging it in now. But, if I add the other TODO items first, the changelog could look so much nicer... Let me see how much progress I can make this weekend.

cl3wis avatar Jul 27 '18 18:07 cl3wis

I'll probably just merge this in tomorrow, unless you want another weekend?

mjpost avatar Aug 01 '18 19:08 mjpost

I guess the data directory can be set easily enough by the user, and I'm not sure that the XDG-specified ~/.local/share/bibsearch/papers offers any significant advantage over ~/.bibsearch/papers, so... maybe it's done?

cl3wis avatar Aug 08 '18 19:08 cl3wis

This a ping for @mjpost and myself (@davvil) to merge this. Somehow I thought it was already taken care of...

davvil avatar Dec 06 '18 16:12 davvil