go-http-file-server icon indicating copy to clipboard operation
go-http-file-server copied to clipboard

Suggestion: archive-dir-user

Open fimmspin opened this issue 1 year ago • 3 comments

Please add possibility to set an archive-dir per user config, as delete-dir-user. Thanks

fimmspin avatar May 06 '24 05:05 fimmspin

If directory is accessible to a user, then it is always possible to download all files one by one. The only different is the user don't need to download one by one manually. So I think the "archive" is not a access control permission. If you want to enable archive for some users, just enable for all users.

But yes this may increase the risk of server loads, even DOS attacks. To make the application simple, currently I choose not adding the per-user archive option.

marjune163 avatar May 06 '24 13:05 marjune163

Yes, you are right, I don't want to enable Archive for all users because i fear that someone may .zip the full content of very very big folders, so causing a server's overload or problem. It may be useful only for a few power-users. I keep it disabled until an --archive-dir-user configuration may be available some time. :) Thanks.

fimmspin avatar May 06 '24 15:05 fimmspin

Version 1.18.1 adds --archive-user and --archive-dir-user.

marjune163 avatar May 31 '24 13:05 marjune163