Matthew Parkinson
Matthew Parkinson
So given we are spending less CPU time, it suggests to me that we are spending too much time in the kernel holding a lock or something. There is one...
@armintoepfer if you have page fault statistics available that might also suggest what is going on. Do you have transparent huge pages switched on on the machine? I think the...
@armintoepfer thanks for this information. I have not seen this level of difference in page faults before. I will run some benchmarks with the `MIMALLOC_LARGE_OS_PAGES=1` setting, to try to dig...
@armintoepfer that is a very good point. It would interesting to know the page fault number for the non-tuned version.
@nwf yeah, I think mimalloc is probably using 1GiB huge pages in that configuration, so that is why there are very few page faults when it is tuned. With regard...
@armintoepfer Thanks. for running this. It does suggest there is opportunity for optimisation in one case, it is no where near enough to account for the difference. I will try...
@armintoepfer in the LTO/PGO case how are you compiling snmalloc? Are you including [malloc.cc](https://github.com/microsoft/snmalloc/blob/master/src/override/malloc.cc) and [new.cc](https://github.com/microsoft/snmalloc/blob/master/src/override/new.cc) and adding them to your build? Or are you building the `.a` and linking...
Looks like ``` extern "C" void* enclave_snmalloc_chunkmap_global_get(snmalloc::PagemapConfig const**); extern "C" void* host_snmalloc_chunkmap_global_get(snmalloc::PagemapConfig const**); ``` in main.cc should be ``` extern "C" void* enclave_snmalloc_chunkmap_global_get(snmalloc_enclave::PagemapConfig const**); extern "C" void* host_snmalloc_chunkmap_global_get(snmalloc_host::PagemapConfig const**); ```...
So those statistics are pretty heavy weight, and were not designed for production. More for working out what snmalloc is doing wrong. They have not really been maintained. There are...
@schrodingerZhu are you able to try #404 for your use case? This getting pretty stable now, and should address your concern about holding on to OS memory. What is the...