Mark Jordan

Results 231 comments of Mark Jordan

Adding `$reader->stripBOM(TRUE);` within the CsvToMods parser's `getMappingsArray()` isn't working. Going to continue trying.

That's a good idea. I think if we added an entry to the `[CONFIG]` settings section dynamically (i.e., if the `--verbose` option was passed on the mik command line), we...

Looking into this a bit more I am leaning toward having this toolchain only produce - the MODS datastream and - the OBJ datastream corresponding to the main file associated...

@whikloj thanks for pointing this out. We welcome PRs ❤️ Your #400, and #406, #407, #414, and the now-closed #25 and #365 are all along the same lines.... we want...

Well, we shouldn't be requiring an unsupported version of PHPUnit, that's for sure. I see no problem in moving our minimum PHP version to 5.6 if that will allow us...

@MarcusBarnes good point:: > However, we should consider this carefully, since folks may be using MIK to migrate to newer systems so that they can actually get ride of older...

@whikloj and @MarcusBarnes I'm missing something. Our .travis.yml file specifies PHP 7 and the PHPUnit tests pass. Is that because when Travis runs it tests in PHP 7, it is...

Hm. The mystery deepens. If no tests are executed (which is is what it says), why do https://travis-ci.org/MarcusBarnes/mik/jobs/247984075#L245 and https://travis-ci.org/MarcusBarnes/mik/jobs/247984075#L256 exist? Also, I'm pretty sure I've pushed up commits that...

Fair enough, I was assuming that if no tests ran, PHPUnit wouldn't exit with a 0.

Could be addressed using either, but I'm not sure about "better" since if we use the row number in the CSV, the filename will have some traceable relation to the...