added note to table docs about images and lineheight

[hayden-t]

[iRyusa]

I'm fine adding something like this in the doc, but it's not really related to MJML this is how HTML/CSS and browsers works in general. mj-table isn't the only one affected you can do the same within mj-text. Maybe it should be mentioned in a new troubleshoot section of the doc

On Wed, Apr 16, 2025 at 12:12 AM hayden-t @.***> wrote:

---

You can view, comment on, or merge this pull request online at:

https://github.com/mjmlio/mjml/pull/2948 Commit Summary

• ade5cb7 https://github.com/mjmlio/mjml/pull/2948/commits/ade5cb7d26b446d5f868a93a910de1cee77252fd Update README.md

File Changes

(1 file https://github.com/mjmlio/mjml/pull/2948/files)

• M packages/mjml-table/README.md https://github.com/mjmlio/mjml/pull/2948/files#diff-21c17ff4143a27abb199a96f5a06834ca8d3d9c4c73c4d606cefaf890ca019ef (2)

Patch Links:

• https://github.com/mjmlio/mjml/pull/2948.patch
• https://github.com/mjmlio/mjml/pull/2948.diff

— Reply to this email directly, view it on GitHub https://github.com/mjmlio/mjml/pull/2948, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAELHTIGAVVJN7F5KMNUS732ZV743AVCNFSM6AAAAAB3GXZPPGVHI2DSMVQWIX3LMV43ASLTON2WKOZSHE4TONZVGYYDIMA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

[hayden-t]

text has a default line height of 1, not sure if that would behave similarly. but if so it might need a note too, or as you suggest have it somewhere else more 'general tips'

[DazGreerMJ]

Hi @hayden-t, sorry if I've missed the point here but what is the issue with adding images in tables, with respect to the line-height?

We are looking to add a troubleshooting section to the website at some point and I want to understand what this tip is aiming to fix. Thanks

[hayden-t]

Been a while, but this pull request suggests adding : "If you put image/s inside, you will need to set line-height at the td or table level to override the default, so it will display at desired height."

[DazGreerMJ]

Thanks @hayden-t, I understand what you're asking in the PR, I was asking what the specific issue is with adding images to tables with respect to line-height?

I want to determine whether it's right to add this to the documentation (issue with MJML) or whether it would be better served in a troubleshooting section (general HTML issue).

If you're able to supply code in our editor (https://mjml.io/try-it-live) to demonstrate, that would be very helpful. Thanks