mjml icon indicating copy to clipboard operation
mjml copied to clipboard

[Documentation] Change the colours of the code section

Open kud opened this issue 6 years ago • 8 comments

The code on the documention is tough to read. Maybe it's because I'm a bit colourblind but it hurts my eyes to read the code.

image

Some tools:

  • https://accessible-colors.com/
  • https://webaim.org/resources/contrastchecker/

https://codemirror.net/demo/theme.html#material could be nice.

Thank you!

kud avatar Aug 29 '19 16:08 kud

Code's here: https://github.com/mjmlio/slate/tree/master/source/stylesheets

kud avatar Aug 29 '19 16:08 kud

Hey @kud I agree with you, the code colors of documentation hurts our eyes. So I tried this combination without make a big change in actual color palette. First of all, I believe we need to change background-color and his shadows and then, change the red color to another that make more contrast and less brightness. Do you think it could be better like that?

code contrast contrast-ratio

dougfabris avatar Sep 03 '19 03:09 dougfabris

That's really great! Thank you to answer so quickly too!

I'm more than ok with those colours! Good for me.

kud avatar Sep 03 '19 07:09 kud

@kud You're very welcome! The MJML project helps me a lot... I'm always trying to do the same, as I can.

dougfabris avatar Sep 05 '19 02:09 dougfabris

cc @ngarnier

iRyusa avatar Sep 05 '19 14:09 iRyusa

@kud @dougfabris

Is current try it live (https://mjml.io/try-it-live) theme accessible enough ? So we can maybe use this one instead ? Or we should update it to so we can re-use the same on both doc & try it live ?

iRyusa avatar Feb 17 '20 16:02 iRyusa

Yes, it's ok for me, with maybe a darker background.

kud avatar Feb 17 '20 17:02 kud

@iRyusa I agree with @kud. To be more accessible, maybe we will have to use a darker background, to get a nice contrast with the red color. This tool is a good option to check the contrast ratio: https://contrast-ratio.com/

dougfabris avatar Feb 17 '20 18:02 dougfabris