mjml-app
mjml-app copied to clipboard
mjmlio
`setSize` function incorrect signature on Windows
To help us help you, provide as much information as you can. You'll find below a template you can use to submit your issue, but feel free to remove any part that wouldn't be relevant here.
Hello, I want to save screenshot from my MJML template. It seems to don't work for me.
Reproduction Steps:
- I opened my mjml project in mjml app on pc (app version 2.8.0, mjml version 4.0.0)
- I clicked on "screenshot" button
- Nothing happens. I check folder with my project - nothing inside
Expected behavior:
First I want to confirm where screenshots should be saved, and of course I want to make it work for me :D
MJML version:
PC App - 2.8.0 MJML - 4.0.0
Hmm.. that's interesting. I just tested on Windows + Linux and it worked. The screenshots should be generated in your current working directory.
Can you open the developer tools (View -> Toggle Developer Tools), go to the "Console" tab of devtools, then take the screenshot and copy/paste eventual errors here? Thanks !
@meriadec
Here it is. btw, I also tried to export screenshot from vscode and it worked. But I want to use export in app for both mobile and pc view.
Okay so your problem seems to be raised here, and given the error message I will suspect a floating/arithmetical problem.
Can you re-define the dimensions of mobile & desktop ? You can access them in Settings > Preview
@meriadec
Unfortunately it didn't help. I redefine dimensions like you ask.
~~Okaaay I just reproduced the issue. The problem is caused by the missing image in your template. Can you try removing the mj-images tags for those two urls:~~
~~Anyway, that should do the trick for now, but mjml-app should be able to handle that simple case.~~
edit: reproduced problem on windows build, even without missing images 😢 investigation needed
relatable: https://github.com/Microsoft/vscode/issues/26509, https://github.com/electron/electron/issues/7351