boot-react-native icon indicating copy to clipboard operation
boot-react-native copied to clipboard

exclude fakeLocalStorageAndDocument

Open jorda0mega opened this issue 8 years ago • 3 comments

the function fakeLocalStorageAndDocument https://github.com/mjmeintjes/boot-react-native/blob/99f656e86740b13695fc1ff3d86cdbcadfdede62/resources/mattsum/boot_rn/js/goog_base.js#L49 is interfering with firebase's connection to the server. Is there a way to exclude this from the build?

jorda0mega avatar Dec 23 '16 20:12 jorda0mega

Do you know which part of the shim causes these issues?

  • window.localStorage
  • window.document
  • window.location ?

What kind of issue are you seeing?

I'm not sure if these shims are still needed for current versions of boot-reload etc., so it's clearly a good idea to investigate.

pesterhazy avatar Dec 24 '16 13:12 pesterhazy

After looking into this, it looks like boot-reload needs a small patch to work without window.location being present. I've submitted a PR:

https://github.com/adzerk-oss/boot-reload/pull/110

Not seeing any other issues removing fakeLocalStorageAndDocument altogether

pesterhazy avatar Dec 24 '16 13:12 pesterhazy

thanks :) basically all firebase storage remains local, never makes it to the firebase console. Once I took this function out I was able to access the firebase server and also save data correctly. I don't know if that makes sense?

jorda0mega avatar Dec 24 '16 20:12 jorda0mega