Michael MacDonald
Michael MacDonald
@kjacque, @phender: I think we should limit this PR to the original changes on master plus whatever is necessary to get it applied on 2.2. Other improvements should happen in...
@tanabarr: This is a massive PR (+6k,-2k LOC !!). Is there any way to break it into smaller chunks for more targeted reviews? I think it's going to be difficult...
> Is there a master version of this PR, too? Or did that already land? No, not yet. I was initially thinking that this was just a workaround for the...
The release/2.2 branch is closed for landing until 2.2.0 is released.
Sorry I missed the review request on this, must have gotten caught by filters. The approach proposed in the PR may be OK, but I am not convinced that it's...
Oh, I understand the problem now. We shouldn't be appending to the $PATH environment in the parent process; we should only append to the child's environment. This is effectively a...
Thank you for the proposed solution. I have implemented a simpler fix in #11146, please take a look.
> Should there be new entries added to utils/config/daos_agent.yml? > Yes, good catch. I forgot about those. > Also, could I ask for this small change? It would allow functional...
> > I'll merge that in, thanks. Actually, I may try to add a ftest for this work, so that change makes it even easier. Just refreshed this patch. I...
Requesting early reviews while waiting for the base patch to land, TIA.