Martin Losch

Fix surface boundary conditions for TEOS-10

3

## What changes does this PR introduce? This a bug fix towards completing the TEOS-10 implementation ## What is the current behaviour? When using TEOS-10 (`'eosType='TEOS10'`, in `data&PARMS01`), the variable...

alternative way to include new pkg/steep_icecavity

5

## What changes does this PR introduce? Suggestion instead of PR #368. I am opening this PR only to support my review of PR #368: Starting from Ou's careful work,...

further cleaning of pkg/autodiff, pkg/ctrl, if necessary

9

After closing #440, this is a new place for collecting and discussing cleanup of pkg/ctrl and pkg/autodiff. The remaining item on the list was: - adcommon.h establishes the transformation of...

bug in store directives in pkg/bling

2

It is very likely that the TAF store directives in `pkg/bling/blink_light.F` are wrong: 1. 3D fields are saved within `i,j,k` loops, where it would only make sense to save individual...

Since PR #208 the flag `-fixed` is passed to TAF as part of `TAF_EXTRA` if `-nocat4ad` is specified, because "to get the *.flowdir processed correctly", because the flow-files with non-standard...

## What changes does this PR introduce? new feature and some additional tweaks of TAF store directives and cleanup ## What is the current behaviour? - no Neumann boundary condition...

penetrating shortwave fraction as a 3D-field

3

## What changes does this PR introduce? New feature to allow feedback from bgc to physical fields via shortwave penetration; save some computations for constant (in time) shortwave penetration fraction...

bug in ggl90/IDEMIX code?

2

In pkg/ggl90/ggl90_calc.F, `recip_hFacI` (inverse cell thickness of w-cells) is used a few times to scale variables and coefficients, but only when `useIDEMIX=.TRUE.`. Two places, where I think this is wrong...

Following up on merged PR #826, it is unclear if the phase velocity `CL` should be zero in the case of catching a division by zero (as it used to...

Bugs in pkg/layer: Does pkg/layers work in pressure coordinates? and more.

3

- [ ] Comparing `pkg/layers` output for meridional overturning circulation computations between pressure and z-coordinates, I have the impression that `pkg/layers` code does not work properly in pressure coordinates. In...