Martin Losch
## What changes does this PR introduce? remove untested and obsolete ECCO_CTRL_DEPRECATED code ## Does this PR introduce a breaking change? This is a major cleanup: The ECCO_CTRL_DEPRECATED flag is...
The generic control variables are a great addition to pkg/ctrl. A very belated thanks to @gaelforget for this contribution! Still there are a few places where we would like to...
Just for reference I am adding the link to GEOMETRIC parameterisation: [Mak et al 2017](https://doi.org/10.1175/JPO-D-18-0017.1) As this has been implemented in the MITgcm, it should be worth the effort to...
Currently we have 4 slightly different files with AD options for TAF/TAMC and one for TAMC only (adjoint_tamc_compatibility) in tools/adjoint_options and two more local copies in local code_ad directories: -...
I noticed that the Makefile for OpenAD experiments does not make sense. After generating it with genmake2 and running `make adAll` once, one cannot run `make adAll` again, because of...
## What changes does this PR introduce? new feature ## What is the current behaviour? quadratic bottom drag has a constant coefficient, inconsistent with the "logarithmic law of the wall"...
The EVP-code is a mess! It has evolved over time accommodated all sorts of different versions. As a consequence, it is very difficult to read and allows only a small...
Non-local vertical mixing models like kpp and ggl90 do not work properly underneath ice shelves. - For pkg/kpp, the surface flux are computed always for k=1, so that there is...
The description of curvilinear grids (including cubed sphere and llc grids) in the manual https://mitgcm.readthedocs.io/en/latest/algorithm/horiz-grid.html#curvilinear-coordinates is incomplete. We should have easily accessible examples (including the necessary data) and maybe describe...
We should probably provide a good recipe for compiling OpenAD as it is not straightforward. Maybe we can use the instructions at the end of this: https://github.com/mjlosch/optim_m1qn3/issues/7 as a starting...