Martin Losch

Results 223 comments of Martin Losch

I think I have caused a little bit of a misunderstanding. The CPP-flags ALLOW_SMOOTH_CORREL2/3D just set different default for the now retired parameters useSmoothCorrel2/3D, which then in turn do not...

For option (2) I can imagine a rewrite of s/r seaice_evp like this: ``` subroutine seaice_evp() ... #ifdef SEAICE_EVP_LEGACY call seaice_evp_legacy() #else c start new routine here ... #endif return...

Hi An, are you aware of exf_iprec_obcs? It defaults to exf_iprec https://github.com/MITgcm/MITgcm/blob/712d4f7047626505053eb8a9c53547f03dbd18c8/pkg/exf/exf_readparms.F#L1009 This parameter applies only if pkg/exf is used, but then it would solve your problem, wouldn't it? I...

``exf_iprec_obcs`` is too used for reading obcs-boundary values. When useEXF=.TRUE., S/R OBCS_PRESCRIBE_READ calls S/R OBCS_EXF_LOAD instead of OBCS_FIELDS_LOAD, S/R OBCS_EXF_LOAD calls OBCS_EXF_READ_(X or Y)Z, which then call EXF_SET_OBCS_(XorY)Z of pkg/exf....

As I have stumbled over closing the salt budget for a linear free surface case (lab_sea) with this combination: ``` rigidLid=.FALSE., implicitFreeSurface=.TRUE., exactConserv = .TRUE., ``` I strongly support the...

Definitely something to talk about in the next dev-meeting. But we could start collecting information here. I have used the default lab_sea experiment (directory input), which uses ``` implicitFreeSurface=.TRUE., exactConserv...

@pletzer Good point! Not all MITgcm simulations use MPI, but there is a routine [ALL_PROC_DIE](https://github.com/MITgcm/MITgcm/blob/master/eesupp/src/all_proc_die.F) that calls MPI_FINALIZE. This routine should be called before a stop statement. A quick search...

So, it's even more involved than I thought, because you need to determine when ALL_PROC_DIE can be called and when we need something different? So we need a routine "EMERGENCY_STOP"...

PR #384 only fixed the problem that viscFacInAd has no effect at all (this was due to store directives that prevented calling mom_calc_visc.F and recomputing viscosities at the beginning of...

I had a quick look at pkg/icefront/icefront_thermodynamics.F and the definitions of `eps3`, `aqe`, and `bqe` are not the same as in pkg/shelfice/shelfice_thermodynamics.F, which makes it a little more involved to...