Martin Losch
@ifenty what about here: https://github.com/MITgcm/MITgcm/blob/53744a46b0e2f5d113df9b8e16499020f53e3471/model/src/solve_for_pressure.F#L231-L249
@jm-c thanks for the careful review. In a few minutes I will push a fix for [pkg/ctrl/ctrl_set_pack_xy.F](https://github.com/MITgcm/MITgcm/pull/631/files/192fc28ff0ecc89b8973115fdbd9c3f7fc5e780b#diff-b8e8ddfd9d9f7389d7eac909be49a80d07bfe9186e4f425c296cbb63ac85d887), remove 5 files from pkg/ecco. I can also remove the seaice_cost_driver.F related files,...
@timothyas @jm-c thanks for all of your comments. I think it's great that we can remove so much more (I was a little timid, because often I had never seen...
> One other thought: could we remove all of the `xx_theta_dummy xx_salt_dummy` etc from the TAF calls? > @timothyas that's the plan for my next PR after this one is...
> I am going to fix exp. tutorial_global_oce_optim (but it's unfortunate that code_ad and code_oad version of the 3 cost_*.F files are no longer identical likely because of indentation, lower/upper...
@timothyas Please check, if the smooth-ctrl code is now removed as intended. Thanks for your help and suggestions! @jm-c I have tried to add documentation as suggested in your points...
@timothyas I can remove the now-retired flags `ctrlSmoothCorrel2/3D` from the verification experiments verification_other/global_oce_cs32 and global_oce_llc90, but this changes the results; currently I am getting for global_oce_cs32: ``` Y Y Y...
I opened [this PR](https://github.com/MITgcm/verification_other/pull/57) to address the issue of `useSmoothCorrel2/3D` in verification_other/global_oce_cs32 and verification_other/global_oce_llc90. Removing these parameters changes the results. I suggest that we (or rather: @jm-c) update the reference...
In https://github.com/ECCO-GROUP/ECCO-v4-Configurations/tree/master/ECCOv4%20Release%205/namelist/data.ctrl I find that these parameters are being used. So I guess that settles it, and we should revert commit [8b54aa5](https://github.com/MITgcm/MITgcm/pull/631/commits/8b54aa5cd157f01beda7abc3f2d4253fa336695f) (although I would still remove the autodiff-flags, as...
Putting back the ALLOW_SMOOTH_CTRL2D code in ctrl_get_gen.F fixes "global_oce_cs32". phew ... There is no ALLOW_SMOOTH_CTRL3D code left (was all within ECCO_DEPRECATED_CODE), so I think we can remove this flag. I...