Martin Losch

Results 223 comments of Martin Losch

I'll push small modifications to the `README.me`. I can also add some links files in the read (e.g. `input.tides/update_TideFileName.sed`), so one can click on this on the web-page, if desired.

I summarise a conversation with @jm-c and @owang01 - it would be nice keep the `steep_icecavity` code in a separate package, but reuse most of the `shelfice` code, so that...

With the latest commit, I can use both 2D and 3D `shiTransCoeffT/S`, but the AD-results change from ``` Y Y Y Y 16>161616 910 8

[b82bbc3](https://github.com/MITgcm/MITgcm/pull/772/commits/b82bbc3ef1efb443ab31314e06a7e037d799e050) fixes the problem with ALLOW_SHITRANSCOEFF_3D, because 1. ALLOW_SHITRANSCOEFF_3D code is only applied to `pkg/steep_icecavity` 2. common blocks for 2D and 3D `shiTransCoeff` a cleanly separated.

I think this is now (nearly) ready for review. There a few things to do: - [ ] work on names: - I changed `IceFront` to `ICF`, `STIC`, or even...

I tried to understand, what the `doscaling` parameter does (by default `doscaling=T`, if you set `xx_gen_preproc` as 'no scaling', the default is changed to `doscaling=F`). Correct me if I am...

Yes, but in #714, we took a different stance and agreed that using `recip_hFacI` in the coefficients `a3d` and `c3d` is correct and now we do it for all cases...

@jm-c is right, and surface heat should not depend on the time step. What would be the natural solution? Instead to prescribing `runoff` and `runoftemp`, one could prescribe `runoff` and...

> I would like to add a new bullet point to the list: seems like the call to `TURNOFF_MODEL_IO` in `ctrl_init_ctrlvar.F` is going to be executed each time a control...

With #788 merged, the mapping of the control variables to indices, grid type etc, is now "safer" in the sense, that there are only two places where the mapping is...