Martin Losch
Martin Losch
Thanks for this suggestion! The key computation was always hard for my to understand, but I never dared to touch this in fear of breaking something that was well tested....
I think that once point 18 is addressed, we should probably close this issue, because it is becoming too long and difficult to read, and open a new ones for...
@jm-c how to you feel about "uppercasing" `ctrl.h` to `CTRL.h`? Should be straightforward, but tedious, because many files (order 146 + 6 in `verification_other`) will change. I am tempted to...
OK, have started that. I made this a separate PR #767 deliberately. I would now start different PR which cleans up `ctrl_dummy.h`, renames it to `CTRL_DUMMY.h` and gets rid of...
We can add these non-TAF experiments: ``` OpenAD.tap_adj: grdchk summary : RMS of 8 ratios = 3.3808379600186E+01 OpenAD.oad: grdchk summary : RMS of 8 ratios = 3.3808379724557E+01 OpenAD.oad.kpp: grdchk summary...
Once #748 is merged, only these experiments with RMS values of `>1e-4` remain: ``` lab_sea OpenAD.oad.ggl90 global_ocean.cs32x15.seaice global_ocean.cs32x15.seaice_dynmix ``` These involve either lab_sea or ggl90, two packages with potentially inaccurate...
@jm-c thanks for taking the initiative here.
@jm-c the current code works and gives reasonable results. The computation of the drag is pretty adhoc and probably in a bad place. For initialisation it may be OK, but...
I like your idea. For now I would put the computation of the drag coefficient into mom_init_fixed.F (there is no mom_init_varia.F), and if we decide to keep this, updating the...
OK, fixed and I followed your suggestions.