Martin Losch

Results 223 comments of Martin Losch

@hajsong thanks for this great contribution. I see that you have added all of the code changes to vermix/code. I think it would be great if you could add the...

Thanks, now I think that most of the files in vermix/code are no longer necessary (because there are copies in pkg/ggl90 and pkg/mom_\*), there's also one experiment failing (aim.5l_cs). Do...

Apart from my inline comment, I have a few things that I could push (more ifs out of loops, integer to floats ...). One addition is related to automatic differentiation...

@hajsong sorry, accidentally I did not post my post last week, which said that I will need some time for this, because I am busy with other stuff. Maybe you...

Another comment: Is this tested anywhere? Can we modify a test by just setting `ctrlDir = './'`?

@owang01 I added ` ctrlDir = 'ctrl_variables'` to lab_sea/input/data.ctrl, removed everything in lab_sea/run/ and reran testreport. The control variables are written to the new subdirectory 'ctrl_variables', but cannot be found...

@jm-c nice description file. I have a few editorial comments. I can either push them or send a version of the README.md to you for evaluation.

> There is one thing that I wanted to do for ocean in P-coord, is to use a more precise conversion factor than just `gravity*rhoConst` when going from z to...

merged PR #649 addresses this issue, so we can close it.