Martin J. Laubach comments

Results 14 comments of


Martin J. Laubach

Change in #121 breaks subsequent model updates in on_commit=True hooks (infinite recursion)

On 14 Sep 2023, at 18:53, Enrique Soria wrote: > Can you try to update django-lifecycle to the latest version? Maybe #121 fixes it #121 CAUSED it. It worked in...

Change in #121 breaks subsequent model updates in on_commit=True hooks (infinite recursion)

Here is a minimal testcase ```python class CommitTrigger(LifecycleModel): foo = models.CharField(max_length=10, blank=True, null=True) foo_ack = models.BooleanField(default=False) t = 0 def __init__(self, *args, **kwargs): super().__init__(*args, **kwargs) self.t = 0 @hook('after_update', when='foo',...

Change in #121 breaks subsequent model updates in on_commit=True hooks (infinite recursion)

> @mjl For your use case, would it work if you change to `BEFORE_SAVE` and remove the `save()`? It would not, I'm afraid. Background info: I use it to model...

Change in #121 breaks subsequent model updates in on_commit=True hooks (infinite recursion)

Anything I can do to help track this down?