Messer icon indicating copy to clipboard operation
Messer copied to clipboard

Add time stamp to messages

Open krunoPeric opened this issue 4 years ago • 6 comments

Summary

It would be great if each message was preceded by a time stamp!

Motivation

Sometimes you want to look back to the date and time of the message.

krunoPeric avatar Jun 20 '20 02:06 krunoPeric

+1.

this is great feature, would be great to enable/dissable in options

michondr avatar Jul 19 '20 07:07 michondr

Hi All,

I would like to work on this.

Question Regarding the feature

@krunoPeric @michondr @tomquirk

Should I just add timestamp to the messages shown in history command?

Will this format be good?

[Date,Timestamp] User name:Message

for example

[11/17/2020, 4:29:30 PM] Ravichandra:Hi

Is it Ok, if the date and time format is the format returned by toLocaleString() ?

Ravichandra-C avatar Nov 19 '20 15:11 Ravichandra-C

toLocaleString should return output most suitable for the user. if you want to make it fancier, you could enable the user to set the format himself

michondr avatar Nov 20 '20 08:11 michondr

Can I send the pull request with toLocaleString?

Ravichandra-C avatar Nov 20 '20 10:11 Ravichandra-C

Yep, this looks great @Ravichandra-C.

tomquirk avatar Nov 20 '20 11:11 tomquirk

Added this feature as part of #165 pull request. @tomquirk @mjkaufer Can you please merge it if the changes looks good? If not, Can you please let me know what else needs to be done?

Ravichandra-C avatar Nov 21 '20 09:11 Ravichandra-C