Benchmark.netCoreMappers icon indicating copy to clipboard operation
Benchmark.netCoreMappers copied to clipboard

feat:MB: remove Newtownsoft.Json and reorder folders

Open maurobernal opened this issue 1 year ago • 1 comments

  • Remove Newtonsoft.Json
  • Change for System.Text.Json
  • Add folder for Dtos and Models

Summary by CodeRabbit

  • New Features

    • Introduced new classes for handling various DTOs (Data Transfer Objects) like ArtistDto, CopyrightDto, ExternalIdsDto, ExternalUrlsDto, ImageDto, ItemDto, TracksDto, and SpotifyAlbumDto.
    • Added a Serialize class for JSON serialization of SpotifyAlbumDto.
  • Updates

    • Updated benchmark results with new performance metrics and environment details.
    • Modified the SpotifyAlbum class and related classes for better structuring.
  • Removed

    • Removed the Newtonsoft.Json package reference.

maurobernal avatar May 23 '24 15:05 maurobernal

Walkthrough

The updates to the ObjectsMapperBenchmark project include the introduction of global using directives, updates to Visual Studio and .NET SDK versions, and enhancements to benchmark results. Additionally, new DTO classes were added, existing DTOs were expanded, and mapping configurations were refactored for stylistic consistency. The Newtonsoft.Json package was removed, and serialization now uses System.Text.Json.

Changes

Files Change Summary
GlobalUsing.cs Introduced global using directives for essential namespaces.
ObjectsMapperBenchmark.sln Updated Visual Studio version information from 15 to 17.
ObjectsMapperBenchmark/BenchmarkContainer.cs Replaced direct assignments with underscore placeholders for mapping configurations.
ObjectsMapperBenchmark/BenchmarkDotNet.Artifacts/results/... Updated benchmark results and performance metrics for various mapping methods.
ObjectsMapperBenchmark/Dtos/ArtistDto.cs Defined ArtistDto class with properties for artist details.
ObjectsMapperBenchmark/Dtos/CopyrightDto.cs Added properties Text and Type with JsonPropertyName attributes to CopyrightDto class.
ObjectsMapperBenchmark/Dtos/ExternalIdsDto.cs Defined ExternalIdsDto class with a Upc property.
ObjectsMapperBenchmark/Dtos/ExternalUrlsDto.cs Defined ExternalUrlsDto class with a Spotify property.
ObjectsMapperBenchmark/Dtos/ImageDto.cs Introduced ImageDto class with properties for Height, Url, and Width.
ObjectsMapperBenchmark/Dtos/ItemDto.cs Added multiple properties to ItemDto class for item details.
ObjectsMapperBenchmark/Dtos/SpotifyAlbumDto.cs Expanded SpotifyAlbumDto class with additional album details and a JSON deserialization method.
ObjectsMapperBenchmark/Dtos/TracksDto.cs Defined TracksDto class with properties for track details.
ObjectsMapperBenchmark/GlobalUsing.cs Introduced global using directives for essential namespaces.
ObjectsMapperBenchmark/Models/SpotifyAlbum.cs Restructured SpotifyAlbum and related classes into the Models namespace.
ObjectsMapperBenchmark/ObjectsMapperBenchmark.csproj Removed the Newtonsoft.Json package reference.
ObjectsMapperBenchmark/Serialize.cs Introduced Serialize class with a ToJson method for JSON serialization using JsonSerializer.

In the code, a rabbit hops with glee,
Through mappings, DTOs, and JSON spree.
With benchmarks swift and models neat,
It dances on with agile feet.
Global usings make the way,
For tidy code and bright array.
With every change, it leaps so high,
A coder's joy beneath the sky.
🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar May 23 '24 15:05 coderabbitai[bot]