vscode-perforce icon indicating copy to clipboard operation
vscode-perforce copied to clipboard

Can't close the "edit description" editor

Open cross opened this issue 1 year ago • 1 comments

I was looking at #143 , which showed me how to do this editing in a main window (Edit changelist spec). That is likely what I'll use in the future.

But, the pencil icon is for "Edit changelist description". This pulls open a small text editing area, but has no controls. I don't know how to submit changes to it, and in the case where I don't want to do anything I don't know how to close it.

Apologies if this is merely a question, but unless I'm missing something obvious it's a bug that there aren't clear controls for this.

Screenshot 2024-07-22 at 13 45 12

cross avatar Jul 22 '24 17:07 cross

Hi

The keyboard combination is shown in the box when it's empty. (This method of 'submitting' the input is a standard part of vs code and not something controlled by the extension - but we do control what it does - i.e. when you click the pencil it changes the logic so that it edits the existing changelist description instead of creating a new one the next time you press the shortcut.).

For example on macOS the combination is cmd+enter. Screenshot 2024-07-22 at 23 12 26

IIRC it's ctrl+enter on windows or unix by default.

mjcrouch avatar Jul 22 '24 22:07 mjcrouch