vscode-perforce icon indicating copy to clipboard operation
vscode-perforce copied to clipboard

Fixing isDirectory for symlinks

Open jacob-kay2 opened this issue 2 years ago • 2 comments

isDirectory should return True for symlinked directories too. VSCode separates Director + Symlinked Directory. Can result in wrong PWD used for p4 commands.

jacob-kay2 avatar Jun 26 '23 16:06 jacob-kay2

@mjcrouch can you take a look at this?

jacob-kay2 avatar Sep 12 '23 13:09 jacob-kay2

Hi, while in theory it looks ok - I was generally hesitant because symlinks always seem to lead to sticky situations in the different ways that use them. However having had another look I realised this is only used in a couple of places and seems quite low risk.

Nevertheless, ideally if you have any before & after examples of specific cases where the old code breaks (with reference to the features that don't work) and how you set up the dir structure to reproduce it, that would be a help! I'll try to merge / test / release it when I have a little time.

mjcrouch avatar Sep 12 '23 18:09 mjcrouch