vscode-perforce icon indicating copy to clipboard operation
vscode-perforce copied to clipboard

Changelist search - result performance

Open mjcrouch opened this issue 5 years ago • 0 comments

Describe the bug: A changelist search on a particular depot area (using a local file path) resulted in 100 changelists being returned. The changelists are displayed, and the describe command is issued to get the details for the changelists, however the extension host hangs - the changelist details are not populated and no more actions are possible. Seems to be consuming 100% cpu. Not sure if an infinite loop or just very bad performance, but normally have no problems with 100 changelists.. This was on remote ssh and eventually it asks me to reload the window.

Note if I just search for shelved changelists in the same area the issue does not occur...

update - tried the same depot area locally on windows. Eventually it does load but takes a long time and the treeview becomes very slow. Presumably there is a changelist with a very large number of files which slows it down.

From recollection this area did have tens of thousands of small files that were all deleted at once not so long ago, so this probably isn't a very common occurence, but should consider how performance can be improved - break up describe command (not sure if this will help the remote extension stay alive)? limit number of files shown per changelist in the tree?

Expected behavior: The changelist details should be populated and further actions should be possible

To Reproduce: tbd

Versions & Details:

  • Perforce extension: 4.11
  • VSCode version: 1.47
  • Operating System: RHEL via remote ssh (need to try windows)
  • Perforce server details (if known):
  • Are you using a multi-root workspace?: No

Additional context

Please open view -> Output, select "Perforce Log" from the dropdown and paste it here, if possible / relevant

mjcrouch avatar Jul 13 '20 10:07 mjcrouch