Marcus Jaschen

icon indicating a website link https://marcusjaschen.com/ icon indicating an email [email protected]

icon company MTB-News.de icon location Berlin/Brandenburg, Germany icon location Keeping things running @ MTB-News.de, Rennrad-News.de, eMTB-News.de, Nimms-Rad.de

Results 33 comments of Marcus Jaschen

Replace the magic getters/setters with non-magic ones

(for later reference) The Collmex API uses ~~six~~seven different data types[1]: - alpha-numerical (i.e. “strings”) - numerical, integer: an ordinary integer value - also used for IDs: in this case...

Sort out the return type of ParserInterface::parse

Looking from the implementation side (*SimpleParser.php*) `string[][]` would be the correct answer[1] as the parser returns an array of parsed CSV lines which are arrays of strings. When processing the...

Refactor Request::send and the ResponseFactory

ZipResponses are returned for several types (Quotations, Orders, Invoices, Deliveries). From a library user's perspective I'd prefer an implementation described as item (2). To clarify: - You propose extending the...