collmex

collmex copied to clipboard

## `PurchaseOrder` `supplier_zip` → `supplier_zipcode` `supplier_tel` → `supplier_phone` `supplier_tel2` → `supplier_phone2` `supplier_telefax` → `supplier_fax` `supplier_account_number` → `supplier_bank_account` `supplier_bank_routing_number` → `supplier_bank_code` `supplier_different_dipositor` → `supplier_bank_account_owner` `supplier_IBAN` → `supplier_bank_iban` `supplier_bank_BIC` → `supplier_bank_bic` `supplier_bank`...

mjaschen

mjaschen

Replace the magic getters/setters with non-magic ones

6

The `AbstractType::__get` and `AbstractType::__set` do not allow static analysis for cases where they are used. I'd like to deprecate them and replace them with explicit `get` and `set` methods together...

oliverklee

Use more specific types instead of `array` in the PHPDoc type annotations

2

E.g., `string[]`. This will help static code analysis. I will create a PR for this.

oliverklee

Sort out the return type of ParserInterface::parse

2

I've found this with the help of Psalm. Should it be `string[]` or `string[][]`? And if it is a `string[][]`, why does `CsvResponse::parseCsv` pass in a `string`, not a `string[]`?

oliverklee

Refactor Request::send and the ResponseFactory

2

Currently, `Request::send` can return either a `ZipResponse` or a `CsvResponse` (depending on the MIME type of the HTTP response). Both Response classes share the same interface `ResponseInterface`. However, this interface...

oliverklee

Update phpunit/phpunit requirement from ^10.0 to ^11.2

1

Updates the requirements on [phpunit/phpunit](https://github.com/sebastianbergmann/phpunit) to permit the latest version. Release notes Sourced from phpunit/phpunit's releases. PHPUnit 11.2.6 Changed #5880: Add hints to CLI parameter deprecation messages How to install...

dependabot[bot]