Michael Jansen

Results 209 comments of Michael Jansen

> @nhaagen Do we understand why the tests don't run? @mjansenDatabay plz halp. Here I am. ``` _____________________________________________ //:::::::::::::::::::::::::::::::::::::::::::::\\ //:::_______:::::::::________::::::::::_____:::::::\\ //:::_/ _-"":::_--""" """--_::::\_ ):::::::::\\ //:::/ /:::::_" "-_:::\/:::::|^\:::\\ //:::/ /~::::::I__ \:::::::::|...

You called me, and you didn't need me :(. I am feeling so useless^^.

Hello @pascalseeland , any objections? Best regards, Michael

@klees I added you as reviewer cause you and your team did a lot of work in the error handling.

Thx for the PR @utesche . I suggest to cast the values in the variable assingment. Instead of: ```php $code_local_roles = []; ``` AND ```php $code_data = ilRegistrationCode::getCodeData($code); if ($code_data["role_local"])...

@utesche Do have time/energy and want to include the review remarks into your PR?

@pascalseeland Please check my suggested change and merge the PR afterwards, if you don't have any further objections.

Hi @iszmais, thx for your pull request. Unfortunately, there is currently no one who feels responsible for this code. We will discuss this kind of PR during the next JF...

The following files should be also provided as public asset: - components/ILIAS/Forum/js/autosave.js - components/ILIAS/Chatroom/js/chat.js - components/ILIAS/Chatroom/js/iliaschat.jquery.js - components/ILIAS/Chatroom/sounds/receive.mp3 - components/ILIAS/Chatroom/sounds/receive.ogg - components/ILIAS/Chatroom/templates/default/style.css - public/components/ILIAS/Contact/BuddySystem/js/buddy_system.js