Michael Jackson

I'm running Mint on Node version 0.1.32, which is the most recent version before the net2 merge. The submodule update was the right thing to do. I'll be sure and...

Probably not. In that case, maybe we rename this to react-router-codemod?

@cpojer in that case you should call it react-or-other-fb-codemod :P If you guys would like to move this into react-router proper go for it. But we should either rename it...

@cpojer Relax, it was a joke

I'm down w whatever you guys want to do. I haven't worked on this at all. Was just looking through repos and this one stood out because of the name....

I think the right fix here is to `encodeURIComponent` any `:param` values in `generatePath`. Note that this does not include `*` params since the glob is intended to match multiple...

Looking into this a bit further, it looks like this behavior was introduced in https://github.com/ShogunPanda/milo/commit/04f3673e4af1f435ebcf9e1d65ee30f2dd3383cd#diff-a439b77f7755dc3c938b4e914e26d1bbabc3e72060ad35824cbcbf26b90ad9a8R50

I actually had a similar thought about the 2nd `signal` arg. In addition to eliminating the function overload, this API would provide a convenient spot to put other [`addEventListener` options](https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener#options),...

> The concern of this PR would be obviated if there was a this.on() method on `Remix.Handle`. I agree with @aleclarson. Ryan and I have discussed a potential `this.on` API,...