m2r icon indicating copy to clipboard operation
m2r copied to clipboard

[fix] TypeError coming from suffix arg removed from sphinx v3.0.0

Open CrossNox opened this issue 4 years ago β€’ 7 comments

Since 1.8.0, the suffix argument for app.add_source_parser() has been deprecated. And it is removed now.

Fix and mantain backwards compatibility for older sphinx versions.

Closes #51

CrossNox avatar Apr 06 '20 14:04 CrossNox

@miyakogi If you get time to review this it would be great.

matthewfeickert avatar Apr 13 '20 05:04 matthewfeickert

@miyakogi ping. No project that uses m2r builds using the latest Sphinx. This includes all projects on Readthedocs.io (that use m2r).

basnijholt avatar Jun 22 '20 15:06 basnijholt

@basnijholt You can try @qhua948's fork, published as m2rr.

sbliven avatar Jun 29 '20 07:06 sbliven

I've finally released my fork as m2r2 after revamping some of the tooling and building CD and testing pipelines.

CrossNox avatar Jul 12 '20 01:07 CrossNox

Any comments on how https://github.com/qhua948/m2rr and https://github.com/CrossNox/m2r2 differ? Maybe only time will tell us which one will be maintained πŸ˜„

basnijholt avatar Aug 03 '20 14:08 basnijholt

This is great, thanks guys, will make a massive difference once it's merged. I'm now using m2r2 and seems to work quite well πŸ‘

axsaucedo avatar Aug 28 '20 10:08 axsaucedo

Codecov Report

Merging #55 (ee7c818) into dev (66f4a5a) will increase coverage by 0.13%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #55      +/-   ##
==========================================
+ Coverage   96.14%   96.27%   +0.13%     
==========================================
  Files           3        3              
  Lines         778      779       +1     
==========================================
+ Hits          748      750       +2     
+ Misses         30       29       -1     
Impacted Files Coverage Ξ”
m2r.py 93.59% <100.00%> (+0.32%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 66f4a5a...ee7c818. Read the comment docs.

codecov-io avatar Dec 01 '20 17:12 codecov-io