mixxx icon indicating copy to clipboard operation
mixxx copied to clipboard

Published 20 hours ago • verified publisher icon mixxxdj

PollingControlProxy refactoring

Open daschuer opened this issue 1 year ago • 6 comments

This is the first PR with non conflicting changes after my original attempt, waiting here: https://github.com/daschuer/mixxx/tree/controlproxylt2

This replaces some ControlProxies with PollingControlProxies and avoids heap allocation

daschuer avatar Aug 02 '22 21:08 daschuer

Now with an improved commit message.

daschuer avatar Aug 03 '22 21:08 daschuer

LGTM. Thank you!

ferranpujolcamins avatar Aug 04 '22 16:08 ferranpujolcamins

Done.

daschuer avatar Aug 04 '22 20:08 daschuer

Rebased to fix CI issue

daschuer avatar Aug 06 '22 21:08 daschuer

@daschuer do you want to work more on this? Or can it be merged?

ferranpujolcamins avatar Aug 10 '22 12:08 ferranpujolcamins

@Swiftb0y This is ready for merge.

daschuer avatar Aug 10 '22 12:08 daschuer