BaseSqlTableModel: disable undesirable sorting

[davidchocholaty]

Fixes undesirable tracks sorting in tables. The mentioned situation could have occurred if the star rating was changed for some tracks and then after the action of removing tracks, adding tracks or filtering, the tracks were sorted.

So, when removing tracks now tracks are kept at the same position for a user. With adding tracks the new tracks are added at the end of the tracks table. The automatic sorting is kept when it is changed between track tables, for example between crates and tracks.

Fixes: lp:1387373 "Remove a track from a crate triggers sorting" Reported by: Jean Claveau

[ronso0]

Thank you for working on this issue!

Does this bug occur in Mixxx 2.3.2? If so, the fix should go to the 2.3 branch. Please rebase and force-push.

[uklotzde]

Thank you for working on this issue!

Does this bug occur in Mixxx 2.3.2? If so, the fix should go to the 2.3 branch. Please rebase and force-push.

Such a ~~massive~~major and risky change is not supposed to go into a bugfix release.

[ronso0]

Thank you for working on this issue! Does this bug occur in Mixxx 2.3.2? If so, the fix should go to the 2.3 branch. Please rebase and force-push.

Such a ~massive~major and risky change is not supposed to go into a bugfix release.

Oh wow, I didn't look at the change set. You're totally right.

[daschuer]

Thank you for this not that easy first PR. It took me a while to wrap my head around it.

It solves the issue, but for my understanding it needs some tweaks. I have found two remaining issues:

• After dropping a file to a playlist, another random file is selected.
• Dropped files into a crate are now sorted in the end, which is out of sight for a big crate. A feedback is missing if the file is now part of the crate or not.

I think we should either resort after dropping a file, or place it where it was dropped.

[github-actions[bot]]

This PR is marked as stale because it has been open 90 days with no activity.