mixxxdj
Solves problem with special characters in path to stems
This change solves the problem when special charactersare in the name of the directories containing stems. In my case ' •' See issue #13783.
This code was copied from the FFMPEG sounds source so it is probably impacting this one too. Shall we fix it as well?
This code was copied from the FFMPEG sounds source so it is probably impacting this one too. Shall we fix it as well?
The change is IN the ffmpeg sound source so it's already fixed. I don't know if this solution only fixes the problem on windows or also on other OS's.
@Eve00000 Will you add a unit test as suggested by Antoine, or should we merge it as it is?
I also wanted to check some other soundsources, I wanted to add a test file to the test routines with a name that contains a special character in a directory with a special character. but I'm not there yet. (doing something else at the mometn, you'll see)
Looked through the other sound sources. None are using toLocal8Bit and are all passing the correct encoding of filenames.
Let's merge this fix this now! @Eve00000 Just create a new PR to add the test for this, when it's ready!
Hi @Eve00000,
it looks like we have not collected the formal agreement form you to distribute you changed with Mixxx. Can you singn: https://docs.google.com/a/mixxx.org/spreadsheet/viewform?formkey=dEpYN2NkVEFnWWQzbkFfM0ZYYUZ5X2c6MQ And comment here when done.
Thank you.
This PR got merged into main one year ago. Shouldn't it be in 2.6 branch already?
I think it should, but it's only in main. 2.6: https://github.com/mixxxdj/mixxx/blob/5df3bb2d113f897a4b65c044b93b6b5e354d41ae/src/sources/soundsourceffmpeg.cpp#L291-L293
Do you mind pushing the backport? Or shall I?
If you could add some test case as well, this would be awesome, tho definitely not a blocker 😃 I assume the backport should address #15681