LFO reset function for effects units

[manulpatel]

Fix for #11496

Added LFO reset function in enableState to trigger its reset when effect is activated.

[daschuer]

Thank you for the fix. Is there something still to do or can you remove the draft state?

Before we can merge it we need you permission to distribute you changes with Mixxx. So please sign: https://docs.google.com/a/mixxx.org/spreadsheet/viewform?formkey=dEpYN2NkVEFnWWQzbkFfM0ZYYUZ5X2c6MQ and comment here when done.

[daschuer]

I have just changed the merge target to 2.4. Can you rebase and force push your branch?

git rebase --onto 2.4 HEAD~1
git push -f

[manulpatel]

While forking I just forked the main branch of the repo. Now to rebase, do I need to fork again with 2.4 branch and then rebase?

[ronso0]

No, you just need to rebase.

[daschuer]

Thank you. The CI failure is unrelated to this PR I have restarted the CI, maybe it disappears. Now we need your signature and you need to remove the draft state and this is ready to go. Thank you.

[manulpatel]

Okay got it! Signed the form.

[ferranpujolcamins]

@daschuer can this be merged?

[LibreTechnica]

Revisiting this, could we see see if the desired sound would come if line 230 from the pull request was changed to pState->lfoFrames = 1? If afforded some time, I can try to compile this myself to confirm what value needs to be there, but I'm almost certain it's not 0.

[github-actions[bot]]

This PR is marked as stale because it has been open 90 days with no activity.

[github-actions[bot]]

This PR is marked as stale because it has been open 90 days with no activity.