mixxx icon indicating copy to clipboard operation
mixxx copied to clipboard

Published 20 hours ago • verified publisher icon mixxxdj

Effects manifest defaults

Open Swiftb0y opened this issue 2 years ago • 1 comments

fixes #10834

Swiftb0y avatar Aug 29 '22 20:08 Swiftb0y

This seems like a reasonable solution.

Be-ing avatar Aug 29 '22 21:08 Be-ing

Friendly ping. Also, are we concerned about the $O(n^2)$ complexity? 3rd-party effect plugins could easily have hundreds of parameters.

Swiftb0y avatar Mar 08 '23 16:03 Swiftb0y

Oh thank you for the reminder. This has slipped through.

daschuer avatar Mar 08 '23 22:03 daschuer

I'd like to address the complexity issue first.

Swiftb0y avatar Mar 08 '23 23:03 Swiftb0y

Oh, yes. I have just realized that this does not work, because a stored custom sort order is lost. Maybe we need a different approach. A temp QHash may help to identify lost parameters.

daschuer avatar Mar 09 '23 11:03 daschuer

Tested and ready for review. I think the new code is even simpler.

Swiftb0y avatar Mar 13 '23 17:03 Swiftb0y

@daschuer merge? I tried experimenting with parallel algorithms but we need to link intel tbb for that and I don't feel like bothering with that right now.

Swiftb0y avatar Mar 29 '23 16:03 Swiftb0y