mixxx icon indicating copy to clipboard operation
mixxx copied to clipboard

add 'no effect' to (quick) effect chain selector

Open mixxxbot opened this issue 2 years ago • 2 comments

Reported by: ronso0 Date: 2022-07-05T15:22:04Z Status: In Progress Importance: Wishlist Launchpad Issue: lp1980755 Tags: effects, gui, preferences


It would be helpful to have an empty (quick effect) chain available by default. Furthermore, I think a 'clear effect unit' action in the effect chain settings menu would be a welcome shortcut to clear a unit.

I want to disable all stuff in the audio chain I don't use, both because it's one more thing I'd need to check if something goes wrong (yes, that happens) and because I want to get rid of visual clutter (in the mixer).

Before the effects refactoring there was a '---' Quick Effect item in the EQ preferences which did exactly that. After the refactoring, the quick effect selector was restored in the prefs, though the 'empty' item is just a blank item, not recognized by / retrieved from the effects engine, and thus not valid or available in the quick effect selector.

My current workaround is store an empty chain, go to prefs, drag (copy) it to Quick Effect chains, then select it in the prefs (or mixer).

Would a fix be as easy as having a built-in empty chain? (named '---' like other [empty] selectors)

mixxxbot avatar Aug 23 '22 02:08 mixxxbot

Commented by: daschuer Date: 2022-07-05T15:48:47Z


My guess is yes.

mixxxbot avatar Aug 23 '22 02:08 mixxxbot

Commented by: ronso0 Date: 2022-08-12T20:13:09Z


Turns out a built-in empyt chain preset is not suitable because it can be edited which defeats the purpose. Instead I went the route to work with the '---' items in the comboboxes and adjust the effects manager to deal with that.

~~https://github.com/mixxxdj/mixxx/pull/4892~~ #10859

mixxxbot avatar Aug 23 '22 02:08 mixxxbot