mixxx icon indicating copy to clipboard operation
mixxx copied to clipboard

proposal: reset EQ Kill buttons on track load

Open mixxxbot opened this issue 2 years ago • 9 comments

Reported by: robi970 Date: 2022-03-18T03:04:15Z Status: Confirmed Importance: Wishlist Launchpad Issue: lp1965469 Tags: easy, eq Attachments: [new flag.png](https://bugs.launchpad.net/bugs/1965469/+attachment/5570254/+files/new flag.png)


For the release of the new version of Mixxx I would like to propose a simple addition to the flags in the “equalizer rack” section, as in the image. the current "reset eq knobs on track load" also cancels the possible equalization set by the mixer

mixxxbot avatar Aug 23 '22 02:08 mixxxbot

Commented by: robi970 Date: 2022-03-18T03:04:15Z Attachments: [new flag.png](https://bugs.launchpad.net/mixxx/+bug/1965469/+attachment/5570254/+files/new flag.png)

mixxxbot avatar Aug 23 '22 02:08 mixxxbot

Commented by: daschuer Date: 2022-03-18T05:57:41Z


Do we really need a separate checkbox? I can imagine that it fits all use cases to make the new feature depend on the existing checkbox. What do you think?

mixxxbot avatar Aug 23 '22 02:08 mixxxbot

Commented by: Be-ing Date: 2022-03-18T14:57:22Z


No. Do not break the gain reset option by coupling it with this.

mixxxbot avatar Aug 23 '22 02:08 mixxxbot

Commented by: daschuer Date: 2022-03-18T18:12:21Z


This bug is unrelated to resetting the gain knob.

It is about the reset the EQ kill switched along with the EQ rotary knobs. I don't see a use case to reset the rotary knobs but not the kill switched.

mixxxbot avatar Aug 23 '22 02:08 mixxxbot

Commented by: robi970 Date: 2022-03-19T00:15:23Z


I try to explain myself better with an example

at the moment the settings allow this: □ reset equalizers on track load □ reset gain on track load......

my proposal would be: □ reset EQ KILL on track load □ reset equalizers on track load □ reset gain on track load........

or also: □ reset EQ KILL on track load □ reset equalizers on track load

□ reset gain on track load......

but never: □ reset equalizers on track load □ reset EQ KILL on track load

□ reset gain on track load......

because if I want Mixxx to reset my equalizer knobs when loading a new track, then I will necessarily want to reset the EQ KILL as well. not necessarily the other way around

mixxxbot avatar Aug 23 '22 02:08 mixxxbot

Commented by: daschuer Date: 2022-03-19T07:20:01Z


Will this work for you as well?

□ reset equalizers knobs and kill buttons on track load □ reset gain on track load........

This would be my proffered solution

mixxxbot avatar Aug 23 '22 02:08 mixxxbot

Commented by: robi970 Date: 2022-03-19T14:46:29Z


actually, Daniel, Mixxx already works as you say: when Mixxx clears the tone knobs, it also resets the Kill buttons.

Mine is a feature proposal: separate the reset of the equalizers, from the reset of the EQ Kill.

it makes no difference to those who work on professional systems, but those who have basic mixers may not have the master output equalized and therefore use the channel equalizers to obtain an equalized output. the EQ Kill, on the other hand, are a purely djing function, which therefore can be used for purposes other than equalizer knobs

mixxxbot avatar Aug 23 '22 02:08 mixxxbot

Commented by: ronso0 Date: 2022-08-20T22:28:03Z


Using the deck EQs to equalize the main output is a very unusual, for that there is the Main EQ in the same preferences page.

mixxxbot avatar Aug 23 '22 02:08 mixxxbot

Commented by: daschuer Date: 2022-08-22T07:09:46Z


I think there is a little use case for resetting the kill switches only.

Resetting the EQ knobs put them out if sync. Before the next turn you need to cross unity to adjust them as well. This can be anoying, but to never want to have existential kill switches applied and they don't go out of sync.

I don't use the reset EQ feature because often the previous setting fits the next track as well if you play the same genre and year. More often I forget to set up the other deck as well. I can't remember to adjust the EQs but forget the kill switches.

Does using the main EQ work for you as a solution?

mixxxbot avatar Aug 23 '22 02:08 mixxxbot

What's the situation here? I've been coding for like 10 months and am interested in making my first contribution here.

J-Kappes avatar Jan 11 '23 16:01 J-Kappes

I think this one is still waiting for a contributor. The first step would be to test the current situation in the main branch and discuss a possible change here. Once have a plan, start coding. If you like to start immediately, you can implement the changes that are needed for any of the discussed solutions.

daschuer avatar Jan 11 '23 17:01 daschuer

Indeed, this is not a common case, but there would be a resaonable use case when using controllers.

Since using a controller, one would not want to reset the EQ knobs because that would make them unsinced with the hardware,

But if using EQ kill between track transitions, when loading a new song it would ease tweaking if the EQ kill is already off when loading a new track.

For the UI appearence, I would maybe suggest:

[X] Reset gain on track load [X] Reset EQ on track load --- [X] Reset EQ Kill on track load

If Reset EQ on track load is selected, auto select Reset EQ Kill too, and disable the possibility to change it. If Reset EQ on track load is not selected, allow to change EQ Kill setting.

JosepMaJAZ avatar Jan 13 '23 08:01 JosepMaJAZ

So if it's possible to reset the kill buttons indendently it would be [X] Reset gain on track load [X] Reset EQ on track load [X] Reset EQ Kill on track load

ronso0 avatar Jan 13 '23 09:01 ronso0

Since no one is working on it, I will remove the milestone.

daschuer avatar Aug 10 '23 13:08 daschuer