Hercules inpulse 500 manual

[resetreboot]

trafficstars

Manual for the mapping submitted with MR https://github.com/mixxxdj/mixxx/pull/14316 (originally https://github.com/resetreboot/herimp-500map) and discussed at https://mixxx.discourse.group/t/hercules-djcontrol-inpulse-500/19739/111

Preview: https://deploy-preview-725--mixxx-manual.netlify.app/hardware/controllers/hercules_djcontrol_inpulse_500

[ronso0]

Thanks for the documentation but we add manuals only for built-in mappings. Is there a pending mapping PR for the Inpulse 500 at mixxxdj/mixxx that I missed?

[resetreboot]

Hey, yes, I'm about to do the PR, I've been in talks with m0db about this. I thought you first had to submit the manual before the PR with the mapping, but it will be in the next hour up and ready too.

[ronso0]

Ah okay, great! It's just that there should be a manual PR accompanying the mapping PR so that we can merge both at once.

[acolombier]

It looks like there is a problem with the base of the PR - could you please rebase it?

You should be able to do the following

• git rebase -i upstream/main, assuming 'upstream' is the name of the https://github.com/mixxxdj/manual remote
• Set all the commit to drop or d, except 6595b57 which should remain pick
• git push -f

Let me know if you would like some help on this

[ronso0]

Set all the commit to drop or d

or simpy mark all unrelated lines and remove them (Ctrl+K I think)

[m0dB]

Minor nitpick about the outputs, for the rest it looks all correct and clear. Great job!

[m0dB]

@resetreboot I edited your first comment to point to the MR with the mappings.

[ronso0]

Here's a simple SVG in case you have interest to add and annotate it Hercules-DJInpulse500.svg.zip

[resetreboot]

Thank you @ronso0 I will be looking how to add the SVG's and add some for extra clarifications.

[m0dB]

https://github.com/resetreboot/manual/pull/1 adds the svg that @ronso0 provided. I can annotate the svg (in the same PR or a follow up PR).

@ronso0 where did you get this svg?

[ronso0]

where did you get this svg?

I traced and modified the image from the official manual, no :copyright: issues to be expected.

[m0dB]

The pre-commit failures should be fixed by https://github.com/resetreboot/manual/pull/4

@ronso0 once the pre-commit is fixed, are you okay with merging this?

[ronso0]

And please rebase onto 2.5 (unless I missed that some mapping part requires functions from main branch, of course)

[m0dB]

@ronso0 the font size issue is weird... it looks fine on macOS, and it surprised me the rendering is so different between linux and macOS...

@resetreboot can you do the rebase on the 2.5 branch of the manual?

[ronso0]

@ronso0 the font size issue is weird... it looks fine on macOS, and it surprised me the rendering is so different between linux and macOS...

I don't know where that stems from, maybe a macOS font? One way to fix it is font -> path conversion, once the strings are fixed (which they are for controller labels).

[resetreboot]

Original branch rebased off 2.5! Sorry for the delay, guys, things been a bit busy over here.

[ronso0]

@resetreboot Please rebase onto 2.5

https://github.com/mixxxdj/mixxx/pull/14491 has been merged into 2.5 so let's wrap this up and add the manual. Can you take a look at the open review comments?

[ronso0]

@resetreboot The rebase went wrong. Please fetch mixxx and rebase onto 2.5. in the interactive TODO editor you need to remove any unrelated commits (from 2.6/main?) that you may have picked earlier, so that you see only the Inpulse 500 commits.

[resetreboot]

@ronso0 I don't know what's wrong. It keeps showing those commits, despite using the drop command to just hold the ones we want.

[ronso0]

then please to literally remove them (lines) from the rebase TODO as I wrote.

[ronso0]

Hmm I have no clue what exactly you tried to do (git command..) but I "simply" did git fetch mixxx gh pr checkout -f 725 git rebase -i mixxx/2.5 and removed all unrelated commits (yes, I had to check each of https://github.com/mixxxdj/manual/pull/725/commits to make sure I don't drop anything...)

Then I pushed to my repo (pre-commit urged me to optimize the SVGs) and the result is #759. It looks identical when I compare https://deploy-preview-725--mixxx-manual.netlify.app/hardware/controllers/hercules_djcontrol_inpulse_500 and https://deploy-preview-759--mixxx-manual.netlify.app/hardware/controllers/hercules_djcontrol_inpulse_500

[ronso0]

I'm confident I have all commits, so I'll just push to your branch (yes, that will make the netlify previews identical..)

[ronso0]

CI says it's all good, link check is unrelated.

If there's nothing you'd like to improve, I'll merge this tomorrow. (there can always be a followup with fixes or tweaks)

[ronso0]

Alright, let's go! Thanks for your work @resetreboot @m0dB !