mixpanel-node icon indicating copy to clipboard operation
mixpanel-node copied to clipboard

fix: add missing config.secret to types

Open gierschv opened this issue 2 years ago • 2 comments

The release 0.18.0 broke the usage of this library using TypeScript and secret in the config:

error TS2345: Argument of type '{ host: string; secret: string; debug: boolean; }' is not assignable to parameter of type 'Partial<InitConfig>'.
Object literal may only specify known properties, and 'secret' does not exist in type 'Partial<InitConfig>'.

gierschv avatar Oct 02 '23 11:10 gierschv

Just here to add a +1 confirming that this change works in our codebase, and fixes the type issue noted in the description.

lsthornt avatar Nov 06 '23 21:11 lsthornt

Following up on this thread to see if and when the PR will be merged. Thanks in advance.

mdwallis avatar Jun 21 '24 13:06 mdwallis

Any plans on merging this one? :)

semone avatar Jan 08 '25 13:01 semone

Sorry about the delay, v0.18.1 contains the fix

tdumitrescu avatar Mar 12 '25 20:03 tdumitrescu