mixpanel-js icon indicating copy to clipboard operation
mixpanel-js copied to clipboard

mixpanel.reset() firefox issue

Open eballeste opened this issue 9 years ago • 6 comments

mixpanel.reset() is called when users logout in order to prevent profile hijacking and polluting the alias table since we've found situations where more than one user could sign in from the same computer/browser.

however, when testing the reset() method in firefox, instead of resetting the distinct_id, a new cookie is created with an additional distinct_id.

screen shot 2016-11-14 at 6 50 53 pm

This issue only seems to be happening with firefox. Works as intended in safari/chrome. Have not tested in ie.

eballeste avatar Nov 14 '16 23:11 eballeste

Thanks for bringing this up. To help us reproduce, is there any way you could let us know:

  • the full URL you're seeing this behavior on (subdomains are important)
  • any custom configuration you're passing to mixpanel.init()

?

If any of this info is private or sensitive, just email [email protected] with it.

tdumitrescu avatar Nov 15 '16 03:11 tdumitrescu

Hi, I'm on Chrome and the reset() method does not delete the mp_xxxx cookie on my side... Is it supposed to work ?

vcarel avatar Feb 20 '17 14:02 vcarel

It looks like reset takes time... but when I logout I do a page refresh so to ensure I get started with a new state. So it actually works from time to time.

Why not returning a Promise on reset ?

vcarel avatar Feb 22 '17 08:02 vcarel

There's nothing about the reset code that ought to be anything but instantaneous (https://github.com/mixpanel/mixpanel-js/blob/f21586cf441b5461919bdba1d6257a2e9c084155/src/mixpanel-core.js#L1348-L1356 and https://github.com/mixpanel/mixpanel-js/blob/f21586cf441b5461919bdba1d6257a2e9c084155/src/mixpanel-core.js#L402-L413). This might be more quickly resolved for you by running through your particular setup with our quite knowledgeable and helpful support staff at [email protected].

tdumitrescu avatar Feb 22 '17 17:02 tdumitrescu

So I'm getting a random behaviour. Sometimes it works, most of the time it doesn't. There's no log or anything which can help me to debug.

Le mer. 22 févr. 2017 18:31, tdumitrescu [email protected] a écrit :

There's nothing about the reset code that ought to be anything but instantaneous ( https://github.com/mixpanel/mixpanel-js/blob/f21586cf441b5461919bdba1d6257a2e9c084155/src/mixpanel-core.js#L1348-L1356 and https://github.com/mixpanel/mixpanel-js/blob/f21586cf441b5461919bdba1d6257a2e9c084155/src/mixpanel-core.js#L402-L413). This might be more quickly resolved for you by running through your particular setup with our quite knowledgeable and helpful support staff at [email protected].

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/mixpanel/mixpanel-js/issues/108#issuecomment-281741194, or mute the thread https://github.com/notifications/unsubscribe-auth/ABeD5ekgoGLXY48kAbZu-vaxvLq8IZwnks5rfHDYgaJpZM4Kx9Re .

vcarel avatar Feb 22 '17 17:02 vcarel

Yes, I really think this is a case where you should contact [email protected] to debug 1-on-1 with someone.

tdumitrescu avatar Feb 22 '17 18:02 tdumitrescu