carbon-now-cli icon indicating copy to clipboard operation
carbon-now-cli copied to clipboard

Published 20 hours ago • verified publisher icon mixn

language-map: add support for plain text (.txt)

Open felixge opened this issue 4 years ago • 4 comments

I was just trying to render some plain text files in carbon-now and the auto language detection decided on some weird coloring that doesn't make sense to me. Hopefully 'text' is a better default for .txt files.

felixge avatar Jan 26 '20 13:01 felixge

I’ll take a look at this soon, currently quite swamped. Thank you for your PR! :) @felixge

mixn avatar Jan 29 '20 15:01 mixn

@felixge You probably want to fiddle with carbon-now-cli/src/helpers/language-map.json

To see where npm has installed your package, try npm list -g

(idk about other package managers)

josinalvo avatar Feb 16 '20 15:02 josinalvo

@josinalvo thanks for your suggestion, but isn't that exactly what this PR is doing? : )

felixge avatar Feb 24 '20 08:02 felixge

@felixge sure, I just found a stopgap measure for myself (for another question) and thought it could be useful for you as well

josinalvo avatar Mar 12 '20 01:03 josinalvo

Sorry I never took a look at this. Slowly coming back to this side project. 🙂 I’ve started work on #83 and will look at this PR before I move too far away from the current state of the code base. I’ll either merge or close this soon, just fyi. Closing will happen if I decide to approach the issue differently as part of the v2 update.

Thank you again for your time!

mixn avatar Feb 06 '23 10:02 mixn

@felixge I’m finalizing the huge v2 release, and since literally everything is new ™ I happened to just add it since I had to cover tons of other languages still anyway.

I don’t want to be taking away from you as a contributor, though, so pls let me know how you wanna proceed. If you’re fine with just closing this PR, that’s okay with me, but I can also remove the line, and you can submit a new PR once the v2 branch is merged into master.

carbon-now-cli isn’t using https://github.com/all-contributors/cli/ (yet), otherwise you could have just added yourself there, even if we closed the PR.

Happy to hear your thoughts. :)

mixn avatar May 12 '23 14:05 mixn

Hey @mixn thanks for your message, it's very kind! Let's just close this. I'm happy to hear a new version is coming and that plain text will be supported 🙇.

felixge avatar May 15 '23 11:05 felixge

Appreciate the quick and kind response, Felix. :) Thank you for your understanding and for closing the PR! :)

mixn avatar May 15 '23 12:05 mixn