cors-gate icon indicating copy to clipboard operation
cors-gate copied to clipboard

Published 20 hours ago • verified publisher icon mixmaxhq

Koa version?

Open niftylettuce opened this issue 6 years ago • 7 comments

niftylettuce avatar Sep 05 '17 03:09 niftylettuce

We don't have plans for one, as we're still using Express. But you're welcome to create one and link it here!

bradvogel avatar Sep 05 '17 03:09 bradvogel

@bradvogel are you good with me copying code over to a Koa version as long as I link back here in the README?

OmgImAlexis avatar Sep 21 '17 07:09 OmgImAlexis

Yes - all good! We'll cross link too

bradvogel avatar Sep 21 '17 16:09 bradvogel

What's meant to happen if this if is false?

https://github.com/mixmaxhq/cors-gate/blob/a6bce954ddf66420a645029cf2b8c72e9c90a223/index.js#L87-L92

OmgImAlexis avatar Sep 25 '17 04:09 OmgImAlexis

Here's the Koa version with Ava testing. We just need the above issue resolved and then we'll be at 100% coverage.

Ref: https://github.com/ladjs/koa-cors-gate

OmgImAlexis avatar Sep 25 '17 04:09 OmgImAlexis

Hey @OmgImAlexis, sorry for the late response. If https://github.com/mixmaxhq/cors-gate/blob/a6bce954ddf66420a645029cf2b8c72e9c90a223/index.js#L87-L92 is false, we'll be a little less secure since we won't be able to patch the origin in to try to reject unauthorized cross-origin requests, as described in the comment block above that line. Does that answer your question?

wearhere avatar Oct 02 '17 13:10 wearhere

@OmgImAlexis Is the state of koa-cors-gate stable and complete? I would like to use it, but noticed it's not on NPM.

ronkorving avatar Sep 19 '18 05:09 ronkorving